Remove Allowed::replace and Allowed::take.
#231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I originally implemented Allowed, I made it work with non-Copy types. Allowed::get cannot with with non-Copy types, so I added Allowed::replace to allow client code to read a non-Copy type out of an Allowed buffer. However, during the PR review we changed Allowed to only contain Copy types. Because of this change, I don't anticipate Allowed::replace (and Allowed::take which is built on top of Allowed::replace) seeing much use. This PR removes Allowed::replace and Allowed::take to reduce the amount of `unsafe` in libtock_platferm.
hudson-ayers
approved these changes
Aug 7, 2020
bors bot
added a commit
that referenced
this pull request
Aug 7, 2020
231: Remove `Allowed::replace` and `Allowed::take`. r=hudson-ayers a=jrvanwhy When I originally implemented `Allowed`, I made it work with non-`Copy` types. `Allowed::get` cannot with with non-`Copy` types, so I added `Allowed::replace` to allow client code to read a non-`Copy` type out of an `Allowed` buffer. However, during the PR review we changed `Allowed` to only contain `Copy` types. Because of this change, I don't anticipate `Allowed::replace` (and `Allowed::take` which is built on top of `Allowed::replace`) seeing much use. This PR removes `Allowed::replace` and `Allowed::take` to reduce the amount of `unsafe` in `libtock_platform`. Co-authored-by: Johnathan Van Why <jrvanwhy@google.com>
|
bors r- |
|
Canceled. |
jrvanwhy
added
the
significant
|
I think this is a significant PR as per the code review policy, and so should wait a week before merge. |
alistair23
approved these changes
Aug 10, 2020
|
I believe this PR is ready to merge. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 18, 2020
231: Remove `Allowed::replace` and `Allowed::take`. r=hudson-ayers a=jrvanwhy When I originally implemented `Allowed`, I made it work with non-`Copy` types. `Allowed::get` cannot with with non-`Copy` types, so I added `Allowed::replace` to allow client code to read a non-`Copy` type out of an `Allowed` buffer. However, during the PR review we changed `Allowed` to only contain `Copy` types. Because of this change, I don't anticipate `Allowed::replace` (and `Allowed::take` which is built on top of `Allowed::replace`) seeing much use. This PR removes `Allowed::replace` and `Allowed::take` to reduce the amount of `unsafe` in `libtock_platform`. Co-authored-by: Johnathan Van Why <jrvanwhy@google.com>
|
Build failed: |
|
build failure will be fixed by #232 |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I originally implemented
Allowed, I made it work with non-Copytypes.Allowed::getcannot with with non-Copytypes, so I addedAllowed::replaceto allow client code to read a non-Copytype out of anAllowedbuffer. However, during the PR review we changedAllowedto only containCopytypes. Because of this change, I don't anticipateAllowed::replace(andAllowed::takewhich is built on top ofAllowed::replace) seeing much use. This PR removesAllowed::replaceandAllowed::taketo reduce the amount ofunsafeinlibtock_platform.