make: split out clippy and format targets #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running the tests take a while and sometimes it is helpful to just be able to run clippy quickly.
alistair23
approved these changes
Jan 11, 2024
jrvanwhy
reviewed
Jan 11, 2024
| @@ -33,6 +33,8 @@ usage: | |||
| @echo "Run 'make flash-<board> EXAMPLE=<>' to flash EXAMPLE to a tockloader-supported board." | |||
| @echo "Run 'make qemu-example EXAMPLE=<>' to run EXAMPLE in QEMU" | |||
| @echo "Run 'make test' to test any local changes you have made" | |||
| @echo "Run 'make format' to format any local changes you have made" | |||
There was a problem hiding this comment.
This isn't accurate -- make format checks formatting, but does not change formatting.
I don't want make test to make edits, so we either need to just update the documentation, or have separate actions for "format the code" and "check formatting".
|
|
||
| .PHONY: format | ||
| format: | ||
| LIBTOCK_PLATFORM=nrf52 cargo fmt --all -- --check |
There was a problem hiding this comment.
The clippy and format actions need to depend on toolchain. In retrospect, test should explicitly depend on toolchain -- it currently transitively depends on it through examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the tests take a while and sometimes it is helpful to just be able to run clippy quickly.