Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update github pull request template locations #326

Merged
merged 2 commits into from
Jul 23, 2024
Merged

feat: update github pull request template locations #326

merged 2 commits into from
Jul 23, 2024

Conversation

scottschreckengaust
Copy link
Contributor

@scottschreckengaust scottschreckengaust commented Jul 22, 2024

Include GitHub documented locations for pull request templates.

Motivation

Fixes: #321
GitHub documents other locations for a pull request template.

Proposed Changes

Update the list of pull request template locations to match the documentation.

Test Plan

Run the code on various repositories with additional locations.

Including the other GitHub [documented](https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository) locations for pull request templates.

Signed-off-by: Scott Schreckengaust <scottschreckengaust@users.noreply.github.com>
@scottschreckengaust
Copy link
Contributor Author

Tested via GitHub workflow: https://github.com/scottschreckengaust/repolinter-tester/actions/runs/10049150744

...
2024-07-22T22:13:44.6859788Z ✔ github-pull-request-template-exists: Found file (.github/pull_request_template.md)
...

@hyandell
Copy link
Member

Brilliant - thank you Scott.

Reading the https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository page - it feels like it also says "You can also store multiple pull request templates in a PULL_REQUEST_TEMPLATE subdirectory within the root or docs/ directories"

So, would you say "docs/PULL_REQUEST_TEMPLATE*" should also be added?

Signed-off-by: Scott Schreckengaust <scottschreckengaust@users.noreply.github.com>
@zhaoyuheng200 zhaoyuheng200 merged commit a2f8731 into todogroup:main Jul 23, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github-pull-request-template-exists does not consider all regex
3 participants