Documentation: Clarify basic regexp syntax of TERM in todo.sh list #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And give hints about escaping. Issue raised by todotxt#334
Though the double quoting doesn't do harm when the single backslash is followed by the | character (\| is no valid escape sequence), it's technically more correct to use single quotes, and also is more in line with the quoting advice given directly below it.
karbassi
reviewed
Feb 25, 2021
karbassi
approved these changes
Feb 28, 2021
|
@karbassi It seems like I cannot merge without the travis-ci check passing, not here in GitHub, nor from the command-line:
If I remember correctly, that Travis check has been replaced by the two GitHub actions, anyway. Can you please remove it? |
|
I wish I could. It's been a bug for over a year. I have no idea how to remove it. |
|
Oh, gosh, well, so you're force-pushing the merged branch, then? |
wwalker
pushed a commit
to wwalker/todo.txt-cli
that referenced
this pull request
Sep 19, 2021
…odotxt#335) * Documentation: Clarify basic regexp syntax of TERM in todo.sh list And give hints about escaping. Issue raised by todotxt#334 * Documentation: Correct quoting in todo.sh help list Though the double quoting doesn't do harm when the single backslash is followed by the | character (\| is no valid escape sequence), it's technically more correct to use single quotes, and also is more in line with the quoting advice given directly below it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And give hints about escaping.
Issue raised by #334
master.fixes #XXreference to the issue that this pull request fixes.