-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: electron app #1586
feat: electron app #1586
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
affine-toeverythingBundle maindiff ------------------- Bundle Size Diff -------------------------
@@ EntryPoint: main @@
## master feat/electron +/- ##
===================================================================
< Bundle 3.73 MB 3.74 MB +8 kB(+0.21%)
< Initial JS 2.01 MB 2.01 MB +8 kB(+0.40%)
= Initial CSS 1.92 kB 1.92 kB
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets 35 35
= Chunks 31 31
< Packages 141 142 +1
< Duplicates 1 2 +1
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files
! Avoid cache wasting
@@ EntryPoint: pages/_app @@
## master feat/electron +/- ##
===================================================================
< Bundle 3.62 MB 3.63 MB +8 kB(+0.22%)
< Initial JS 1.9 MB 1.91 MB +8 kB(+0.42%)
= Initial CSS 1.92 kB 1.92 kB
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets 33 33
= Chunks 29 29
< Packages 141 142 +1
< Duplicates 1 2 +1
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files
! Avoid cache wasting
@@ EntryPoint: pages/_error @@
## master feat/electron +/- ##
===================================================================
= Bundle 249 B 249 B
= Initial JS 249 B 249 B
= Initial CSS 0 B 0 B
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets 1 1
= Chunks 1 1
= Packages 1 1
= Duplicates 0 0
...and more |
Size Change: 0 B Total Size: 927 kB ℹ️ View Unchanged
|
Deploying with Cloudflare Pages
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1586 +/- ##
=======================================
Coverage 56.17% 56.17%
=======================================
Files 223 223
Lines 4372 4372
Branches 719 713 -6
=======================================
Hits 2456 2456
+ Misses 1732 1730 -2
- Partials 184 186 +2
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, other than one nit~
fix #1584
electron-forge does not support pnpm: electron/forge#2633
example release: https://github.com/pengx17/AFFiNE/releases/tag/untagged-157b4f318ec7e594b8ba