Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: electron app #1586

Merged
merged 29 commits into from
Mar 16, 2023
Merged

feat: electron app #1586

merged 29 commits into from
Mar 16, 2023

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Mar 15, 2023

@vercel
Copy link

vercel bot commented Mar 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
affine-preview ✅ Ready (Inspect) Visit Preview Mar 16, 2023 at 2:51PM (UTC)
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 16, 2023 at 2:51PM (UTC)

@pengx17 pengx17 temporarily deployed to development March 15, 2023 09:39 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook March 15, 2023 09:40 Inactive
@perfsee
Copy link

perfsee bot commented Mar 15, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master  feat/electron                 +/- ##
===================================================================
< Bundle              3.73 MB        3.74 MB       +8 kB(+0.21%)   
< Initial JS          2.01 MB        2.01 MB       +8 kB(+0.40%)   
= Initial CSS         1.92 kB        1.92 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   35             35                       
= Chunks                   31             31                       
< Packages                141            142                  +1   
< Duplicates                1              2                  +1   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master  feat/electron                 +/- ##
===================================================================
< Bundle              3.62 MB        3.63 MB       +8 kB(+0.22%)   
< Initial JS           1.9 MB        1.91 MB       +8 kB(+0.42%)   
= Initial CSS         1.92 kB        1.92 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   33             33                       
= Chunks                   29             29                       
< Packages                141            142                  +1   
< Duplicates                1              2                  +1   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master  feat/electron                 +/- ##
===================================================================
= Bundle                249 B          249 B                       
= Initial JS            249 B          249 B                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    1              1                       
= Chunks                    1              1                       
= Packages                  1              1                       
= Duplicates                0              0                       

...and more

@vercel vercel bot temporarily deployed to Preview – affine-preview March 15, 2023 09:42 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2023

Size Change: 0 B

Total Size: 927 kB

ℹ️ View Unchanged
Filename Size
apps/web/out/_debug/broadcast.dev.html 1.97 kB
apps/web/out/_debug/init-page.dev.html 1.97 kB
apps/web/out/_next/data/XAacHtV-t9n9DvgD5k3xY/preview/AFFiNE-Docs.json 440 B
apps/web/out/_next/data/XAacHtV-t9n9DvgD5k3xY/preview/Welcome-to-AFFiNE-Abbey-Alpha-Wood.json 1.17 kB
apps/web/out/_next/data/XAacHtV-t9n9DvgD5k3xY/preview/Welcome-to-AFFiNE-Alpha-Downhills.json 840 B
apps/web/out/_next/data/XAacHtV-t9n9DvgD5k3xY/preview/Welcome-to-the-AFFiNE-Alpha.json 878 B
apps/web/out/_next/static/chunks/152-49caaa545f1fbe14.js 2.01 kB
apps/web/out/_next/static/chunks/267.4d3603cdfafb5e3d.js 7.28 kB
apps/web/out/_next/static/chunks/331.76be31c14ce77f6e.js 673 B
apps/web/out/_next/static/chunks/349.f89f0b29750b509c.js 230 kB
apps/web/out/_next/static/chunks/372.a67b088eefe785ff.js 576 B
apps/web/out/_next/static/chunks/425.fce6d2112e6910c6.js 13.8 kB
apps/web/out/_next/static/chunks/489.6f9c072f90835e00.js 7.58 kB
apps/web/out/_next/static/chunks/546.e5e026cc343e3830.js 894 B
apps/web/out/_next/static/chunks/571.34d903720254b523.js 131 kB
apps/web/out/_next/static/chunks/710.672a758dc80e2a95.js 10.8 kB
apps/web/out/_next/static/chunks/740-a1f1cd08d9336e7a.js 3.1 kB
apps/web/out/_next/static/chunks/846.cc0c339b1c8f21ad.js 1.88 kB
apps/web/out/_next/static/chunks/903-35a9587a6c401d2c.js 14.5 kB
apps/web/out/_next/static/chunks/framework-d5b249005e2ab443.js 39.3 kB
apps/web/out/_next/static/chunks/main-da50911484031388.js 26.9 kB
apps/web/out/_next/static/chunks/pages/_app-86e18611667793cb.js 349 kB
apps/web/out/_next/static/chunks/pages/_debug/broadcast.dev-5d50a08b6988ea74.js 760 B
apps/web/out/_next/static/chunks/pages/_debug/init-page.dev-4ed52ce327771511.js 812 B
apps/web/out/_next/static/chunks/pages/_error-0a835540c814fb4b.js 154 B
apps/web/out/_next/static/chunks/pages/404-9651b24adf112de6.js 630 B
apps/web/out/_next/static/chunks/pages/index-f722a1f8d62e5fcf.js 1.01 kB
apps/web/out/_next/static/chunks/pages/invite/[invite_code]-b8a5872e3c5fdace.js 1.17 kB
apps/web/out/_next/static/chunks/pages/preview/[previewId]-fa583a72d25a2d03.js 837 B
apps/web/out/_next/static/chunks/pages/public-workspace/[workspaceId]-b9bf65465df63180.js 1.77 kB
apps/web/out/_next/static/chunks/pages/public-workspace/[workspaceId]/[pageId]-75b8758aa0366f9c.js 1.4 kB
apps/web/out/_next/static/chunks/pages/workspace/[workspaceId]/[pageId]-f1aa83bc7e55f499.js 1.45 kB
apps/web/out/_next/static/chunks/pages/workspace/[workspaceId]/all-7ad5db7543e0a986.js 1.16 kB
apps/web/out/_next/static/chunks/pages/workspace/[workspaceId]/favorite-f98c371be01a63b0.js 920 B
apps/web/out/_next/static/chunks/pages/workspace/[workspaceId]/setting-8879d823109fd3a1.js 1.24 kB
apps/web/out/_next/static/chunks/pages/workspace/[workspaceId]/trash-acd48796d268099f.js 938 B
apps/web/out/_next/static/chunks/polyfills-c67a75d1b6f99dc8.js 28 kB
apps/web/out/_next/static/chunks/webpack-dbefbf7100ccb48a.js 1.77 kB
apps/web/out/_next/static/css/6d2a004cb9e221df.css 689 B
apps/web/out/_next/static/XAacHtV-t9n9DvgD5k3xY/_buildManifest.js 562 B
apps/web/out/_next/static/XAacHtV-t9n9DvgD5k3xY/_ssgManifest.js 111 B
apps/web/out/404.html 2.41 kB
apps/web/out/index.html 2.51 kB
apps/web/out/invite/[invite_code].html 2 kB
apps/web/out/manifest.json 170 B
apps/web/out/preview/AFFiNE-Docs.html 2.9 kB
apps/web/out/preview/Welcome-to-AFFiNE-Abbey-Alpha-Wood.html 3.64 kB
apps/web/out/preview/Welcome-to-AFFiNE-Alpha-Downhills.html 3.3 kB
apps/web/out/preview/Welcome-to-the-AFFiNE-Alpha.html 3.35 kB
apps/web/out/public-workspace/[workspaceId].html 2.02 kB
apps/web/out/public-workspace/[workspaceId]/[pageId].html 2.02 kB
apps/web/out/workspace/[workspaceId]/[pageId].html 2.02 kB
apps/web/out/workspace/[workspaceId]/all.html 2.02 kB
apps/web/out/workspace/[workspaceId]/favorite.html 2.02 kB
apps/web/out/workspace/[workspaceId]/setting.html 2.02 kB
apps/web/out/workspace/[workspaceId]/trash.html 2.02 kB

compressed-size-action

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 15, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 45462b4
Status: ✅  Deploy successful!
Preview URL: https://a0e6f5ef.affine.pages.dev
Branch Preview URL: https://feat-electron.affine.pages.dev

View logs

@pengx17 pengx17 temporarily deployed to development March 15, 2023 09:45 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development March 15, 2023 09:45 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development March 15, 2023 09:45 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development March 15, 2023 09:45 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development March 15, 2023 09:45 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6ae06d5) 56.17% compared to head (45462b4) 56.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1586   +/-   ##
=======================================
  Coverage   56.17%   56.17%           
=======================================
  Files         223      223           
  Lines        4372     4372           
  Branches      719      713    -6     
=======================================
  Hits         2456     2456           
+ Misses       1732     1730    -2     
- Partials      184      186    +2     
Flag Coverage Δ
e2etest 52.97% <ø> (-0.06%) ⬇️
unittest 29.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pengx17 pengx17 temporarily deployed to development March 15, 2023 15:31 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook March 15, 2023 15:32 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview March 15, 2023 15:34 Inactive
@pengx17 pengx17 temporarily deployed to development March 15, 2023 15:36 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development March 15, 2023 15:36 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development March 15, 2023 15:36 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development March 15, 2023 15:36 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development March 15, 2023 15:36 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development March 15, 2023 15:42 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview March 15, 2023 15:43 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook March 15, 2023 15:44 Inactive
@pengx17 pengx17 temporarily deployed to development March 16, 2023 11:05 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview March 16, 2023 11:09 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook March 16, 2023 11:10 Inactive
Copy link
Collaborator

@m1911star m1911star left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than one nit~

apps/electron/layers/main/src/main-window.ts Outdated Show resolved Hide resolved
@pengx17 pengx17 temporarily deployed to development March 16, 2023 13:57 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview March 16, 2023 13:58 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook March 16, 2023 13:59 Inactive
@pengx17 pengx17 temporarily deployed to development March 16, 2023 14:00 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development March 16, 2023 14:00 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development March 16, 2023 14:00 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development March 16, 2023 14:00 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development March 16, 2023 14:00 — with GitHub Actions Inactive
@pengx17 pengx17 enabled auto-merge (squash) March 16, 2023 14:08
apps/electron/README.md Outdated Show resolved Hide resolved
@pengx17 pengx17 temporarily deployed to development March 16, 2023 14:50 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview March 16, 2023 14:50 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook March 16, 2023 14:51 Inactive
@pengx17 pengx17 temporarily deployed to development March 16, 2023 14:53 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development March 16, 2023 14:53 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development March 16, 2023 14:53 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development March 16, 2023 14:54 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development March 16, 2023 14:54 — with GitHub Actions Inactive
@pengx17 pengx17 merged commit 88f662e into master Mar 16, 2023
@pengx17 pengx17 deleted the feat/electron branch March 16, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bare Minimum Electron App setup
3 participants