Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: experimental vite support #239

Closed
wants to merge 2 commits into from
Closed

build: experimental vite support #239

wants to merge 2 commits into from

Conversation

doodlewind
Copy link
Member

@doodlewind doodlewind commented Aug 13, 2022

This PR tries to start the project using vite.

Faster development environment startup allows us to launch a large number of static pages concurrently without packaging, greatly increasing the speed of automated testing in parallel.

Style9 had to be removed here due to the need for an incompatible non-standardized build-time configuration. However, the equivalent standardized code does not actually incur extra maintenance costs. The page style of the Webpack environment on this branch appears to remain normal.

Except for style9, vite requires almost no additional configuration or modification to work (config).

Currently the cold start speed using vite is about 6s.

Try it out locally:

pnpm vite-start:affine

AD900820-0395-45AF-98A4-6562EB7D2F01

Known issue: workspace seems to be staying blank due to routing issues, hopefully someone can try based on this branch if interested in further solutions.

@nx-cloud
Copy link

nx-cloud bot commented Aug 13, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 78fcee5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx run-many --target=lint --all --exclude=components-common,keck,ligo-virgo-e2e,theme,editoe --max-warnings=0
✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Austaras
Copy link
Contributor

Emotion needs on Babel too, I don't believe use vite is possible at this point.

@Proful
Copy link

Proful commented Aug 13, 2022

This is very good effort @doodlewind

@darkskygit
Copy link
Member

close this pr that because we migration to pathfinder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants