Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codec): type rw deadlock #496

Merged
merged 1 commit into from
Aug 1, 2023
Merged

fix(codec): type rw deadlock #496

merged 1 commit into from
Aug 1, 2023

Conversation

forehalo
Copy link
Member

@forehalo forehalo commented Aug 1, 2023

No description provided.

@vercel
Copy link

vercel bot commented Aug 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
octobase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 6:22am

@forehalo forehalo temporarily deployed to development August 1, 2023 06:21 — with GitHub Actions Inactive
@forehalo forehalo temporarily deployed to development August 1, 2023 06:21 — with GitHub Actions Inactive
@darkskygit darkskygit merged commit f7bbc35 into master Aug 1, 2023
@darkskygit darkskygit deleted the fix/codec branch August 1, 2023 06:51
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Benchmark Results

Linux

group                                  master                                 pr
-----                                  ------                                 --
codec/jwst decode var_int (32 bit)     1.00   420.3±26.01µs        ? ?/sec    1.02   428.8±27.20µs        ? ?/sec
codec/jwst decode var_int (64 bit)     1.00   418.0±14.59µs        ? ?/sec    1.01   424.0±19.25µs        ? ?/sec
codec/jwst decode var_uint (32 bit)    1.01   372.3±13.87µs        ? ?/sec    1.00   369.6±17.74µs        ? ?/sec
codec/jwst decode var_uint (64 bit)    1.01   372.7±20.04µs        ? ?/sec    1.00   367.5±18.93µs        ? ?/sec
codec/jwst encode var_int (32 bit)     1.00   588.3±23.40µs        ? ?/sec    1.03   604.4±38.44µs        ? ?/sec
codec/jwst encode var_int (64 bit)     1.00   598.9±28.37µs        ? ?/sec    1.04   622.4±43.08µs        ? ?/sec
codec/jwst encode var_uint (32 bit)    1.01   364.8±16.35µs        ? ?/sec    1.00   359.9±19.21µs        ? ?/sec
codec/jwst encode var_uint (64 bit)    1.00   354.8±17.99µs        ? ?/sec    1.03   365.0±15.00µs        ? ?/sec
codec/lib0 decode var_int (64 bit)     1.01   382.1±17.94µs        ? ?/sec    1.00   379.4±21.60µs        ? ?/sec
codec/lib0 decode var_uint (32 bit)    1.01   334.9±18.51µs        ? ?/sec    1.00   330.0±18.31µs        ? ?/sec
codec/lib0 decode var_uint (64 bit)    1.00   324.8±14.06µs        ? ?/sec    1.02   332.2±24.43µs        ? ?/sec
codec/lib0 encode var_int (64 bit)     1.00   546.5±27.43µs        ? ?/sec    1.00   544.5±25.37µs        ? ?/sec
codec/lib0 encode var_uint (32 bit)    1.01   370.1±18.34µs        ? ?/sec    1.00   368.2±20.18µs        ? ?/sec
codec/lib0 encode var_uint (64 bit)    1.01   371.3±17.04µs        ? ?/sec    1.00   369.4±19.95µs        ? ?/sec
ops/array/jwst/insert                  1.00   469.1±17.62µs        ? ?/sec    1.02   478.6±26.55µs        ? ?/sec
ops/array/jwst/insert range            1.00   640.9±33.12µs        ? ?/sec    1.01   646.1±30.68µs        ? ?/sec
ops/array/jwst/remove                  1.00    325.7±9.17µs        ? ?/sec    1.01   328.3±14.59µs        ? ?/sec
ops/array/yrs/insert                   1.01    117.5±4.32µs        ? ?/sec    1.00    116.7±4.36µs        ? ?/sec
ops/array/yrs/insert range             1.00    148.2±6.26µs        ? ?/sec    1.00    148.5±8.23µs        ? ?/sec
ops/array/yrs/remove                   1.10    134.8±6.48µs        ? ?/sec    1.00    123.1±5.06µs        ? ?/sec
ops/text/jwst/insert                   1.01    194.6±9.88µs        ? ?/sec    1.00    193.2±9.26µs        ? ?/sec
ops/text/jwst/remove                   1.03      3.3±0.11µs        ? ?/sec    1.00      3.2±0.13µs        ? ?/sec
ops/text/yrs/insert                    1.00     54.0±2.56µs        ? ?/sec    1.01     54.4±5.44µs        ? ?/sec
ops/text/yrs/remove                    1.00      3.0±0.10µs        ? ?/sec    1.02      3.0±0.11µs        ? ?/sec
update/parse with jwst/basic.bin       1.02     76.3±3.00µs    71.6 MB/sec    1.00     75.1±2.95µs    72.7 MB/sec
update/parse with jwst/database.bin    1.00     74.4±3.14µs    44.5 MB/sec    1.00     74.6±4.70µs    44.4 MB/sec
update/parse with jwst/large.bin       1.01      4.8±0.20ms    47.4 MB/sec    1.00      4.8±0.19ms    47.7 MB/sec
update/parse with yrs/basic.bin        1.03     60.7±2.10µs    89.9 MB/sec    1.00     58.8±3.00µs    92.8 MB/sec
update/parse with yrs/database.bin     1.00     46.8±2.23µs    70.8 MB/sec    1.00     47.0±1.95µs    70.5 MB/sec
update/parse with yrs/large.bin        1.00      3.0±0.12ms    76.6 MB/sec    1.00      3.0±0.12ms    76.7 MB/sec

Windows

group                                  master                                 pr
-----                                  ------                                 --
codec/jwst decode var_int (32 bit)     1.05   402.7±20.35µs        ? ?/sec    1.00   384.6±26.18µs        ? ?/sec
codec/jwst decode var_int (64 bit)     1.01   388.7±20.75µs        ? ?/sec    1.00   385.0±24.70µs        ? ?/sec
codec/jwst decode var_uint (32 bit)    1.05   361.0±17.58µs        ? ?/sec    1.00   343.0±19.72µs        ? ?/sec
codec/jwst decode var_uint (64 bit)    1.08   367.6±18.68µs        ? ?/sec    1.00   341.8±19.92µs        ? ?/sec
codec/jwst encode var_int (32 bit)     1.00   457.2±25.56µs        ? ?/sec    1.00   458.9±25.56µs        ? ?/sec
codec/jwst encode var_int (64 bit)     1.06   479.2±34.31µs        ? ?/sec    1.00   452.8±29.41µs        ? ?/sec
codec/jwst encode var_uint (32 bit)    1.06   327.2±15.81µs        ? ?/sec    1.00   308.9±17.13µs        ? ?/sec
codec/jwst encode var_uint (64 bit)    1.04   332.9±15.74µs        ? ?/sec    1.00   318.7±20.29µs        ? ?/sec
codec/lib0 decode var_int (64 bit)     1.05   330.7±19.12µs        ? ?/sec    1.00   316.4±19.12µs        ? ?/sec
codec/lib0 decode var_uint (32 bit)    1.00   279.1±16.08µs        ? ?/sec    1.02   284.8±14.70µs        ? ?/sec
codec/lib0 decode var_uint (64 bit)    1.01   272.3±17.68µs        ? ?/sec    1.00   269.3±15.15µs        ? ?/sec
codec/lib0 encode var_int (64 bit)     1.03   465.1±28.11µs        ? ?/sec    1.00   451.0±28.81µs        ? ?/sec
codec/lib0 encode var_uint (32 bit)    1.00   328.8±18.37µs        ? ?/sec    1.03   339.3±28.90µs        ? ?/sec
codec/lib0 encode var_uint (64 bit)    1.07   331.7±22.41µs        ? ?/sec    1.00   309.5±16.65µs        ? ?/sec
ops/array/jwst/insert                  1.03   475.2±23.51µs        ? ?/sec    1.00   459.8±32.77µs        ? ?/sec
ops/array/jwst/insert range            1.07   635.3±24.10µs        ? ?/sec    1.00   593.2±35.54µs        ? ?/sec
ops/array/jwst/remove                  1.04   302.2±12.78µs        ? ?/sec    1.00   290.2±14.74µs        ? ?/sec
ops/array/yrs/insert                   1.01    128.2±5.39µs        ? ?/sec    1.00    126.4±8.43µs        ? ?/sec
ops/array/yrs/insert range             1.01    169.7±8.69µs        ? ?/sec    1.00   168.7±10.10µs        ? ?/sec
ops/array/yrs/remove                   1.14    197.2±6.92µs        ? ?/sec    1.00    172.6±9.64µs        ? ?/sec
ops/text/jwst/insert                   1.00   201.7±12.32µs        ? ?/sec    1.07    216.0±9.99µs        ? ?/sec
ops/text/jwst/remove                   1.00      3.4±0.18µs        ? ?/sec    1.02      3.5±0.16µs        ? ?/sec
ops/text/yrs/insert                    1.07     55.3±2.00µs        ? ?/sec    1.00     51.5±2.69µs        ? ?/sec
ops/text/yrs/remove                    1.12      4.7±0.17µs        ? ?/sec    1.00      4.2±0.20µs        ? ?/sec
update/parse with jwst/basic.bin       1.07    118.5±6.76µs    46.1 MB/sec    1.00    110.5±5.35µs    49.4 MB/sec
update/parse with jwst/database.bin    1.00     83.9±4.72µs    39.5 MB/sec    1.01     84.7±5.37µs    39.1 MB/sec
update/parse with jwst/large.bin       1.00      5.3±0.30ms    43.4 MB/sec    1.08      5.7±0.23ms    40.3 MB/sec
update/parse with yrs/basic.bin        1.03     75.0±4.20µs    72.8 MB/sec    1.00     73.0±3.74µs    74.8 MB/sec
update/parse with yrs/database.bin     1.01     58.3±2.90µs    56.8 MB/sec    1.00     57.5±3.06µs    57.6 MB/sec
update/parse with yrs/large.bin        1.00      3.6±0.24ms    64.3 MB/sec    1.11      3.9±0.35ms    57.9 MB/sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants