fix(edgeless): fix frame not update in collaboration (#5232)

toeverything · Nov 7, 2023 · a572bd9 · a572bd9 · vercel · Nov 7, 2023
1 parent 2f248df
commit a572bd9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/packages/blocks/src/page-block/edgeless/components/block-portal/frame/edgeless-frame.ts b/packages/blocks/src/page-block/edgeless/components/block-portal/frame/edgeless-frame.ts
@@ -60,8 +60,14 @@ export class EdgelessFramesContainer extends WithDisposable(ShadowlessElement) {
   }
 
   protected override firstUpdated() {
-    this._disposables.add(
-      this.surface.page.slots.historyUpdated.on(() => this.requestUpdate())
+    const { _disposables, surface } = this;
+
+    _disposables.add(
+      surface.page.slots.blockUpdated.on(({ flavour }) => {
+        if (flavour === FRAME) {
+          this.requestUpdate();
+        }
+      })
     );
 
     this.surface.edgeless.slots.edgelessToolUpdated.on(tool => {

diff --git a/packages/store/src/workspace/page.ts b/packages/store/src/workspace/page.ts
@@ -70,6 +70,7 @@ export class Page extends Space<FlatBlockMap> {
       | {
           type: 'add';
           id: string;
+          flavour: string;
         }
       | {
           type: 'delete';
@@ -80,6 +81,7 @@ export class Page extends Space<FlatBlockMap> {
       | {
           type: 'update';
           id: string;
+          flavour: string;
           props: Partial<BlockProps>;
         }
     >(),
@@ -522,6 +524,7 @@ export class Page extends Space<FlatBlockMap> {
 
     this.slots.blockUpdated.emit({
       type: 'update',
+      flavour: model.flavour,
       id: model.id,
       props,
     });
@@ -724,7 +727,7 @@ export class Page extends Space<FlatBlockMap> {
       return;
     }
 
-    this.slots.blockUpdated.emit({ type: 'add', id });
+    this.slots.blockUpdated.emit({ type: 'add', id, flavour: model.flavour });
   }
 
   private _handleYBlockDelete(id: string) {