feat(edgeless): support rotating shapes #2931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch is running in CodeSandbox. Use the links below to review this PR faster. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fundon
force-pushed
the
0601-support-rotating-shapes
branch
from
c700db0
to
422c3b1
Compare
doodlewind
reviewed
Jun 5, 2023
|
|
||
| color: string; | ||
| } | ||
|
|
||
| export const DebugElementDefaultProps: IElementDefaultProps<'debug'> = { | ||
| type: 'debug', | ||
| xywh: '[0,0,0,0]', | ||
| rotate: 0, |
There was a problem hiding this comment.
I think using xywhr that packs rotate value may be a better choice.
There was a problem hiding this comment.
Well, we can add rotate at the end.
There was a problem hiding this comment.
I think we can consider adding the matrix, width height fields.
doodlewind
reviewed
Jun 5, 2023
| @@ -9,26 +9,31 @@ import type { ShapeMethods } from '../types.js'; | |||
| export const DiamondMethods: ShapeMethods = { | |||
| render( | |||
| ctx: CanvasRenderingContext2D, | |||
| matrix: DOMMatrix, | |||
There was a problem hiding this comment.
@Flrande are there render methods still being used after you switch to roughjs?
* master: feat: update edgeless toolbar ui and zoom bar position (toeverything#3281)
doodlewind
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2608
update hover-rectflip shapesremoved this featureScreen.Recording.2023-06-21.at.2.48.16.AM.mov
Screen.Recording.2023-06-21.at.5.19.09.AM.mov
Screen.Recording.2023-06-23.at.12.06.36.PM.mov