Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prepend "https" if url without protocol when bookmark click to open #3277

Merged
merged 2 commits into from
Jun 30, 2023
Merged

fix: prepend "https" if url without protocol when bookmark click to open #3277

merged 2 commits into from
Jun 30, 2023

Conversation

QiShaoXuan
Copy link
Contributor

@QiShaoXuan QiShaoXuan commented Jun 30, 2023 •
edited
Loading

fixed: #2601

@codesandbox
Copy link

codesandbox bot commented Jun 30, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@vercel
Copy link

vercel bot commented Jun 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2023 2:36pm
blocksuite-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2023 2:36pm

doodlewind
doodlewind approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for maintaining this one!

@doodlewind doodlewind enabled auto-merge (squash) June 30, 2023 10:05
@doodlewind doodlewind merged commit 9848f61 into toeverything:master Jun 30, 2023
19 checks passed
fundon added a commit to fundon/blocksuite that referenced this pull request Jul 1, 2023
@fundon
Merge branch 'master' into 0601-support-rotating-shapes
6b0a30c 
* master:
  fix: missing blob mime types in IndexedDB (toeverything#3280)
  fix: link confirm btn should change color when link valid (toeverything#3276)
  refactor: replacing whitespace with ` ` (toeverything#3279)
  feat: improve page metadata UI (toeverything#3275)
  feat: rename bookmark property title to bookmarkTitle (toeverything#3278)
  fix: missing title when exporting markdown (toeverything#3273)
  fix: prepend "https" if url without protocol when bookmark click to open (toeverything#3277)
  fix: typo (toeverything#3274)
@QiShaoXuan QiShaoXuan deleted the fix/bookmark-open branch July 4, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlewind doodlewind doodlewind approved these changes

Assignees

@QiShaoXuan QiShaoXuan

Labels
None yet
Projects
AFFiNE Project
Archived in project
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect opened link URL
2 participants
@QiShaoXuan @doodlewind