Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(edgeless): support top-level image block inside surface #4894

Merged
merged 17 commits into from
Oct 11, 2023
Merged

feat(edgeless): support top-level image block inside surface #4894

merged 17 commits into from
Oct 11, 2023

Conversation

regischen
Copy link
Contributor

@regischen regischen commented Sep 25, 2023 •
edited by doodlewind
Loading

close #3594

Edit:

  • The new top-level blocks are now wrapped into the edgeless-block-portal entry.
  • The EdgelessSelectableMixin is now decorating the ImageBlock component.
  • Added index / xywh / rotate fields in image block model.

@vercel
Copy link

vercel bot commented Sep 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 10:18am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2023 10:18am

@regischen regischen marked this pull request as ready for review September 26, 2023 06:22
@doodlewind doodlewind self-assigned this Sep 26, 2023
@doodlewind doodlewind changed the title feat(edgeless): top-level image feat(edgeless): support top-level image block inside surface Sep 26, 2023
@doodlewind doodlewind added the notable Major improvement worth emphasizing label Sep 26, 2023
@Flrande
Copy link
Member

Flrande commented Sep 28, 2023

image

doodlewind
doodlewind reviewed Oct 10, 2023
View reviewed changes
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image dragged from native OS window is still inserted with the note block wrapper.

Screen.Recording.2023-10-10.at.08.50.59.mov

doodlewind
doodlewind approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should land this after the cleanups, thanks for the feat.

@regischen regischen merged commit 763786d into master Oct 11, 2023
18 checks passed
@regischen regischen deleted the feat-top-level-image branch October 11, 2023 10:29
@doodlewind doodlewind mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawvs lawvs lawvs left review comments

@doodlewind doodlewind doodlewind approved these changes

Assignees

@doodlewind doodlewind

@regischen regischen

Labels
notable Major improvement worth emphasizing
Projects
AFFiNE Project
Archived in project
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support top-level image block in whiteboard
4 participants
@regischen @Flrande @doodlewind @lawvs