feat(edgeless): support more connector arrow style #5064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
doodlewind
approved these changes
Oct 24, 2023
| @@ -969,7 +969,7 @@ export class EdgelessConnectorManager { | |||
| const start = this._getConnectorEndElement(connector, 'source'); | |||
| const end = this._getConnectorEndElement(connector, 'target'); | |||
|
|
|||
| const [startPoint, endPoint] = this._computeStartEndPoint(connector); | |||
| const [startPoint, endPoint] = this._computeStartEndpoint(connector); | |||
There was a problem hiding this comment.
Note that "endpoint" itself is a non-synthetic word, which can be confused with the endPoint here (within the context of startPoint / endPoint). Could you try to avoid the startPoint / endPoint naming to
reduce the potential cost of understanding?
There was a problem hiding this comment.
Sure, I'll try to avoid it.
|
Need to update diamond, triangle, arrow to add rounded corners.
|
|
Please use new design of triangle |
hwangdev97
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To close #4501
Screen.Recording.2023-10-20.at.16.58.16.mov