Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: surface-ref interaction && failed test in AFFiNE #5242

Merged
merged 17 commits into from
Nov 8, 2023
Merged

fix: surface-ref interaction && failed test in AFFiNE #5242

merged 17 commits into from
Nov 8, 2023

Conversation

doouding
Copy link
Member

@doouding doouding commented Nov 7, 2023 •
edited
Loading

  • No need to slice the note when inserting the surface-ref block
  • Add "Insert into page" button

@vercel Vercel
Copy link

vercel bot commented Nov 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 2:17am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2023 2:17am

@doouding doouding changed the title fix: surface-ref selection issue && note merge issue fix: surface-ref interaction && failed test in AFFiNE Nov 7, 2023
@doouding doouding marked this pull request as ready for review November 8, 2023 02:03
doodlewind
doodlewind approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feat!

@doodlewind doodlewind merged commit 75db32f into master Nov 8, 2023
18 checks passed
@doodlewind doodlewind deleted the fix/add-surface-ref branch November 8, 2023 02:28
@doouding doouding mentioned this pull request Nov 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlewind doodlewind doodlewind approved these changes

Assignees

@doouding doouding

Labels
None yet
Projects
AFFiNE Project
Archived in project
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doouding @doodlewind