Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backwards compatible with remote selection #5364

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

lawvs
Copy link
Collaborator

@lawvs lawvs commented Nov 17, 2023

Fix the error log in toeverything/AFFiNE#4980

Screenshot 2023-11-17 at 21 42 08
slot.js:99 [
  {
    "code": "invalid_type",
    "expected": "boolean",
    "received": "undefined",
    "path": [
      "isReverse"
    ],
    "message": "Required"
  }
]

Since the remote data is unreliable, we should ignore the error when parsing failure.

Copy link

vercel bot commented Nov 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 1:55pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Nov 17, 2023 1:55pm

Copy link
Collaborator

@Saul-Mirone Saul-Mirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doodlewind doodlewind merged commit f0fae3d into master Nov 17, 2023
18 checks passed
@doodlewind doodlewind deleted the fix/backwards-compatible branch November 17, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants