Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(page): autoIdentityLink behavior #5370

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

AyushAgrawal-A2
Copy link
Contributor

@AyushAgrawal-A2 AyushAgrawal-A2 commented Nov 20, 2023

closes #4371

Current Behavior: autoIdentifyLink executes on every key press. On typing inside the link triggers autoIdentifyLink, changing the link text and url

Changes:

  • autoIdentifyLink executes only on pressing space after a non-link element.
  • typing within the link element only changes the link text.

p.s.: popup on pasting a link is handled in affine, ref #4371 (comment)

Copy link

vercel bot commented Nov 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2023 3:43am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2023 3:43am

@Flrande Flrande merged commit a42b9d2 into toeverything:master Nov 23, 2023
21 checks passed
@AyushAgrawal-A2 AyushAgrawal-A2 deleted the ayush/4371 branch November 23, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

Incorrect autoIdentifyLink behavior
2 participants