feat(page): support embed view for certain attachment types

[lawvs]

Fix #3641 #5033

This PR may need to undergo UI review.

There is a new property that has been added to the attachment model.

export type AttachmentBlockProps = {
  /**
   * Whether to show the attachment as an embed view.
   */
  embed: boolean | BackwardCompatibleUndefined;
}

Screen.Recording.2023-11-27.at.19.46.25.mov

Known issues

• The selection can not go through the iframe. The embed bookmark also has the same problem.

This issue can be resolved by applying a transparent layer over the iframe.

Screen.Recording.2023-11-28.at.02.19.09.mov

• The PDF will reset to page 0 when the page reloads. I think it's reasonable, as it is difficult to control the expected page number unless we add a new options button.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
blocksuite	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 28, 2023 4:25pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
blocksuite-docs	⬜️ Ignored (Inspect)	Visit Preview		Nov 28, 2023 4:25pm

[doodlewind]

Thanks for the update! We've discussed and confirmed this basically match the roadmap, but will be great if some UI setup could be optimized. For example, could you add #toolbar=0 to the embed PDF url, so that the PDF toolbar could be hidden?

[doodlewind]

Any recommended practice as alternative?

[lawvs]

Since the hasBlob is similar to getAttachmentBlob, I have migrated to getAttachmentBlob.

But neither of them is a best practice. the BlobManager needs to be refactored to meet the following requirements:

• A new head API, also known as has, needs to be added to check a blob.
• The get and set methods should return an Object that contains a stream to make it easier to check the progress of the upload or download.
• The list API should have a default maximum limit and the ability to be adjusted by its options.

I think the cloudflare R2 workers API is a good reference.

[doodlewind]

Looks good to land, thanks!