refactor: @blocksuite/editor -> @blocksuite/presets
#5570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
doodlewind
added
breaking
Saul-Mirone
reviewed
Dec 5, 2023
| @@ -190,7 +190,7 @@ export const PagePreset: BlockSpec[] = [ | |||
| }, | |||
| }, | |||
| }, | |||
| embedGithubBlockSpec, | |||
| EmbedGithubBlockSpec, | |||
| ]; | |||
|
|
|||
| export const EdgelessPreset: BlockSpec[] = [ | |||
There was a problem hiding this comment.
We may also want to rename _presets in blocks to _blocks
There was a problem hiding this comment.
How about make it _specs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to expose more prebuilt editors and auxiliary components under the concept of preset. The auxiliary components will be defined as fragments.
EditorPresets includeDocEditor,EdgelessEditorand more.FragmentPresets include AI copilot panel and TOC panels, which shares the block tree under the samepageinstance, but may not share the same lifecycle of the editor component.Migration steps:
EditorContainerkept for backwards compatibility.