Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(edgeless): support frame sidebar #5584

Merged
merged 35 commits into from
Dec 8, 2023
Merged

feat(edgeless): support frame sidebar #5584

merged 35 commits into from
Dec 8, 2023

Conversation

donteatfriedrice
Copy link
Member

@donteatfriedrice donteatfriedrice commented Dec 6, 2023 •
edited
Loading

Frames sidebar design: https://www.figma.com/file/ry2HHWu5XafpuXBD2XOvKd/%F0%9F%9B%96-2023.S4?node-id=2677%3A19552&mode=dev

Feature:

  1. Display all frame with real-time preview.
Screen.Recording.2023-12-15.at.17.59.04.mov

@vercel Vercel
Copy link

vercel bot commented Dec 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2023 5:08am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Dec 8, 2023 5:08am

@donteatfriedrice donteatfriedrice marked this pull request as draft December 6, 2023 01:47
@donteatfriedrice donteatfriedrice marked this pull request as ready for review December 8, 2023 03:58
@doodlewind doodlewind added the notable Major improvement worth emphasizing label Dec 8, 2023
@doodlewind doodlewind changed the title feat(edgeless): frames sidebar feat(edgeless): support frame panel Dec 8, 2023
@doodlewind doodlewind changed the title feat(edgeless): support frame panel feat(edgeless): support frame sidebar Dec 8, 2023
@doodlewind doodlewind added the ui-style Related to UI styling label Dec 8, 2023
doodlewind
doodlewind approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this iteration cycle, we should land this and finish the AFFiNE integration process, UI reviews feedback could be fixed in PRs afterwards.

@doodlewind doodlewind merged commit b3213bb into toeverything:master Dec 8, 2023
21 checks passed
@zanwei
Copy link
Member

zanwei commented Dec 8, 2023 •
edited
Loading

Had a discussion with @donteatfriedrice, there're some feedback needs to be update

  1. Frame Sidebar still functions independently after switching back to Editor.
  2. The style of the sidebar thumbnail Fill needs to be changed, please just refer to the design.
  3. When Fill is turned on, the playback should fill the full screen. This is enough for now.

and also there're some UI feedback needs to be update

  1. Please Update the font-size of title and serial number, also adjust the padding to 18px
    image

  2. Please make sure the title section is aligned with the content
    image

  3. Please change the padding from 12px to 16px

image

@donteatfriedrice donteatfriedrice deleted the feat/frames-sidebar branch December 10, 2023 13:53
@donteatfriedrice
Copy link
Member Author

donteatfriedrice commented Dec 15, 2023 •
edited
Loading

Features:
2. Support clicking to select frame.
3. Support shift-click to multi-select.
4. Support clicking blank area to de-select.
5. Support double click to fit the frame to screen.

Screen.Recording.2023-12-15.at.17.58.01.mov

@donteatfriedrice
Copy link
Member Author

donteatfriedrice commented Dec 15, 2023 •
edited
Loading

Feature:
6. Support frame navigator settings and enter presentation mode.

Screen.Recording.2023-12-15.at.17.59.54.mov

@donteatfriedrice
Copy link
Member Author

Feature:
7. Support DnD to reorder frames.

Screen.Recording.2023-12-15.at.18.01.59.mov

@donteatfriedrice
Copy link
Member Author

donteatfriedrice commented Dec 15, 2023 •
edited
Loading

Feature:
8. Support double click to switch to edgeless mode and navigate to the frame.

Screen.Recording.2023-12-15.at.18.02.54.mov

@donteatfriedrice
Copy link
Member Author

Feature:
9. Support editing frame title.

Screen.Recording.2023-12-15.at.18.06.34.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlewind doodlewind doodlewind approved these changes

@doouding doouding Awaiting requested review from doouding

@regischen regischen Awaiting requested review from regischen

@zanwei zanwei Awaiting requested review from zanwei

Assignees

@donteatfriedrice donteatfriedrice

Labels
notable Major improvement worth emphasizing ui-style Related to UI styling
Projects
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@donteatfriedrice @zanwei @doodlewind