-
-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(edgeless): support consistent dragging behavior #5613
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
c542fe9
to
d259e32
Compare
d259e32
to
a568457
Compare
a568457
to
73e2c03
Compare
73e2c03
to
acc7366
Compare
acc7366
to
c3abd0d
Compare
c3abd0d
to
da6e1e2
Compare
0194a97
to
5f4ad08
Compare
5f4ad08
to
14ef97d
Compare
14ef97d
to
d0ce586
Compare
d0ce586
to
e6ce089
Compare
e6ce089
to
faca561
Compare
faca561
to
4f558ee
Compare
565b88e
to
52b599d
Compare
fbbe5c0
to
1bead15
Compare
2719331
to
6adae94
Compare
c0a6546
to
ec84515
Compare
ec84515
to
a8f4309
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, we should definitely land this!
Two minor issues:
- After dragging out an image, you can undo this operation, but unable to redo it back:
Screen.Recording.2023-12-14.at.21.51.31.mov
This usually happens due to unexpected side effect (model mutation) that comes with the undo, which resets the history stack.
- After dragging an image inside the note, the first undo/redo pair works fine. But from this moment, it requires 2 undo operations to make actual undo effect:
Screen.Recording.2023-12-14.at.21.56.45.mov
This usually happens when page.captureSync()
is called during a series of model operations, which will add one undo step.
By default, the UndoManger
merges all operations from the same user during about 500ms (even if these operations are using multiple page.transact
calls) into one undo step. Using page.captureSync()
is the way to add more undo steps manually. For certain cases (e.g., batch adding images), adding more undo steps allows user to undo each operation one after another.
closes #5561
Changes:
In edgeless mode,