refactor(edgeless): surface elements api #5874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
This is almost ready. We can book a meeting to review the code and discuss the technical details tomorrow. @doodlewind |
|
I have corrected some issues with variable naming:
And add generic type to |
doodlewind
reviewed
Jan 3, 2024
Yes, but I'm not planning to do this in this PR. I'll start a new PR on cleanup and replacement or something once this gets merged. |
doodlewind
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move surface elements related API onto the surface model. Introduce a new pure data element model to replace the existing one to make it independent from the renderer. Additionally, this new element model will not depend on the DOM API.