Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(edgeless): auto-complete displays incorrect shape #6334

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

lawvs
Copy link
Collaborator

@lawvs lawvs commented Feb 29, 2024

Fix #6322

This pull request adds a draw function to the shape utils.

This allows the AutoCompleteOverlay to render different shapes.

Screenshot 2024-02-29 at 17 32 00

Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 29, 2024 9:31am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Feb 29, 2024 9:31am

Copy link
Member

@donteatfriedrice donteatfriedrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks for the fix!

@donteatfriedrice donteatfriedrice merged commit 8d040fb into master Feb 29, 2024
21 checks passed
@donteatfriedrice donteatfriedrice deleted the fix/auto-complete-ellipse branch February 29, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

AutoCompleteOverlay displays the wrong shape when the shape is an ellipse
2 participants