Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(page): upgrade shiki from 0.14.7 to 1.1.7 #6354

Merged
merged 6 commits into from
Mar 4, 2024

Conversation

lawvs
Copy link
Collaborator

@lawvs lawvs commented Mar 3, 2024

This pr upgrade shiki from 0.14.7 to 1.1.7

Shiki 1.0 underwent a major rewrite by antfu last month.

With the new version, code blocks no longer require static assets or CDN settings.

Shiki 1.0 Release log
https://github.com/shikijs/shiki/releases/tag/v1.0.0
shikijs/shiki#557

Shiki Migration Guide
https://shiki.style/guide/migrate

Copy link

vercel bot commented Mar 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2024 8:13pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Mar 3, 2024 8:13pm

@lawvs lawvs changed the title Refactor and upgrade shiki refactor(page): upgrade shiki from 0.14.7 to 1.1.7 Mar 3, 2024
`<pre><code class="code-python"><span style="word-wrap: break-word; color: #81A1C1;">import</span><span style="word-wrap: break-word; color: #D8DEE9FF;"> this</span></code></pre>`
`<pre><code class="code-python"><span style="word-wrap: break-word; color: #AF00DB;">import</span><span style="word-wrap: break-word; color: #000000;"> this</span></code></pre>`
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-03-04 at 03 31 43

Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the bump!

@doodlewind doodlewind merged commit c8aaa43 into master Mar 4, 2024
21 checks passed
@doodlewind doodlewind deleted the chore/upgrade-shiki branch March 4, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants