Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blocks): switch to file-type v19.1.0 #7523

Merged
merged 1 commit into from
Jul 11, 2024
Merged

fix(blocks): switch to file-type v19.1.0 #7523

merged 1 commit into from
Jul 11, 2024

Conversation

lawvs
Copy link
Collaborator

@lawvs lawvs commented Jul 9, 2024

This pull request is for sunsetting the @sgtpooki/file-type and using the official file-type v19.1.0.

The file-type package has replaced the usage of node:buffer with Uint8Array. This change allows it to run safely in the browser now.

The file-type package is used in the attachment-block and image-block modules to determine the file type of uploaded files.

Related to #6803 sindresorhus/file-type#578 (comment)

Copy link

vercel bot commented Jul 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 3:09am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2024 3:09am

Copy link

graphite-app bot commented Jul 9, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@fourdim fourdim added the merge label Jul 10, 2024
Copy link

graphite-app bot commented Jul 10, 2024

Merge activity

  • Jul 9, 11:07 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 9, 11:07 PM EDT: fourdim added this pull request to the Graphite merge queue.
  • Jul 9, 11:15 PM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Playground E2E test (1)').

This pull request is for sunsetting the `@sgtpooki/file-type` and using the official file-type v19.1.0.

The `file-type` package has replaced the usage of `node:buffer` with `Uint8Array`. This change allows it to run safely in the browser now.

The file-type package is used in the attachment-block and image-block modules to determine the file type of uploaded files.

Related to #6803 sindresorhus/file-type#578 (comment)
@graphite-app graphite-app bot removed the merge label Jul 10, 2024
@Saul-Mirone Saul-Mirone merged commit 2c0ceb8 into master Jul 11, 2024
19 checks passed
@Saul-Mirone Saul-Mirone deleted the fix/file-type branch July 11, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants