Fix compilation of traverseTuple under new match types restrictions (Scala 3.4+) #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WojciechMazur
requested review from
Odomontois,
road21 and
mikhailchuryakov
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've found out in the Open Community Build that this project fails to build under Scala 3.4+. It's due to SIP-56 changes to the Scala match types scala/scala3#18262, especially a change introduced in scala/scala3@5260c60 made the type reduction of
headvariable to be no longerA *: restbut(T & (A *: rest))instead. This lead to further type mismatch errors when compiling.I'm proposing a change that should both fix the issue and simplify the code. Running tests locally finished successfully using both Scala 3.1.3 (used in the project) and 3.5.0 (latest stable)