Migrate train_on_inputs to sft-specific params #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connermanuel
commented
Apr 21, 2025
There was a problem hiding this comment.
formatting only
connermanuel
force-pushed
the
cmanuel/eng-24978-move-train_on_inputs-to-the-parameters-of-sft-training
branch
from
4b502d1 to
8ef8769
Compare
connermanuel
force-pushed
the
cmanuel/eng-24978-move-train_on_inputs-to-the-parameters-of-sft-training
branch
from
8ef8769 to
1ce13d6
Compare
timofeev1995
reviewed
May 9, 2025
| ) | ||
| train_on_inputs = "auto" | ||
|
|
||
| if dpo_beta is not None and training_method != "dpo": |
There was a problem hiding this comment.
Other option might be just a warning. What do you think?
artek0chumak
requested changes
May 9, 2025
There was a problem hiding this comment.
Don't forget version bump up: https://github.com/togethercomputer/together-python/blob/main/pyproject.toml#L15
|
|
||
| if train_on_inputs is None and training_method == "sft": | ||
| log_warn_once( | ||
| "train_on_inputs is not set for SFT training, it will be set to 'auto' automatically" |
There was a problem hiding this comment.
Suggested change
| "train_on_inputs is not set for SFT training, it will be set to 'auto' automatically" | |
| "train_on_inputs is not set for SFT training, it will be set to 'auto'" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adjusts the behavior of train_on_inputs.
if train type is SFT, we include this parameter in the TrainingMethod and default it to auto.
if train type is DPO, we default to None and raise if parameter is supplied.