Accept strings for checkpoint type on download #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh I see the confusion. I wanted to pass a string, but it's designed to take one of I think string makes the most sense (and matches the cli), but having it accept either might be easiest for users. |
mryab
reviewed
May 7, 2025
|
@mryab , @artek0chumak , What do you think of it now? |
nbroad1881
commented
May 8, 2025
| DownloadCheckpointType.MERGED, | ||
| DownloadCheckpointType.ADAPTER, | ||
| }: | ||
| url += f"&checkpoint={checkpoint_type.value}" | ||
| else: | ||
| raise ValueError( | ||
| f"Invalid checkpoint type for LoRATrainingType: {checkpoint_type}" |
There was a problem hiding this comment.
I think this error will never be reached because of the check in lines 614:620, so we can delete this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to check string value.