Use /checkpoints instead of events parsing #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artek0chumak
reviewed
May 8, 2025
src/together/resources/finetune.py
Outdated
| @@ -551,7 +594,7 @@ def list_events(self, id: str) -> FinetuneListEvents: | |||
|
|
|||
| return FinetuneListEvents(**response.data) | |||
|
|
|||
| def list_checkpoints(self, id: str) -> List[FinetuneCheckpoint]: | |||
| def list_checkpoints_from_events(self, id: str) -> List[FinetuneCheckpoint]: | |||
There was a problem hiding this comment.
Let's delete the old function
mryab
reviewed
May 9, 2025
src/together/resources/finetune.py
Outdated
| @@ -551,7 +594,7 @@ def list_events(self, id: str) -> FinetuneListEvents: | |||
|
|
|||
| return FinetuneListEvents(**response.data) | |||
|
|
|||
| def list_checkpoints(self, id: str) -> List[FinetuneCheckpoint]: | |||
| def list_checkpoints_from_events(self, id: str) -> List[FinetuneCheckpoint]: | |||
src/together/resources/finetune.py
Outdated
| checkpoint_path = checkpoint["path"] | ||
| step = checkpoint["step"] | ||
|
|
||
| is_final = int(step) == 0 |
There was a problem hiding this comment.
By the way, this feels a bit brittle — what if for some reason we did save a checkpoint at step 0? I wonder if we can add a new field to the FinetuneCheckpoint that indicates that this is a final checkpoint
src/together/resources/finetune.py
Outdated
| if checkpoint_path.endswith("_adapter"): | ||
| checkpoint_type = "Final Adapter" | ||
| else: | ||
| checkpoint_type = "Final Merged" if had_adapters else "Final" |
There was a problem hiding this comment.
I think it's more correct to either detect this from the training type or move the checkpoint naming to the backend side (because you'll have to make 2 requests otherwise)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you read the Contributing Guidelines?
Describe your changes