Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RMT primitives #543

Merged
merged 88 commits into from
Mar 15, 2022
Merged

Add RMT primitives #543

merged 88 commits into from
Mar 15, 2022

Conversation

lask
Copy link
Contributor

@lask lask commented Mar 7, 2022

No description provided.

Lau Skorstengaard added 30 commits February 21, 2022 09:18
WIP
2370109
WIP
6343c01
WIP
f17391f
WIP
77800f1
First stab at primtiives
c464665
Add lib file
e7173e8
Update primitive parameter amount
facddf1
Add primitives
b594a5f
Add resource group
bf0f0c6
WIP on toit level rmt lib
ddb7f99
Add config to controller
059f50f
Add transfer and read to controller
57e2ab1
Add == operator to item
5d62fe0
SWap Item from bytes constructor argument
8d94d13
Add tests
00c6d23
Update config primitives
37815f7
WIP
c6020e5
Merge remote-tracking branch 'origin/master' into lask-rmt-primitives
e7ca700
Fix RMT item serialization
7ca4dc4
Add Item Toit doc
c03fd2c
Check for error when starting rx
f3ad028
Add TODO
aaaa4bf
Fix value initialization in Item construction from bytes
56d7467
Add item serialization test
2a34f29
This seems to work
4ee9959
Remove val to item test primitive
72e16ae
Update comment with reason for external allocation
a7e4491
Remove debug printing
6aea331
Reset RX memory
0465f9e
Add reset mem comment
84af9c8
@lask lask requested a review from erikcorry March 11, 2022 09:24
erikcorry
erikcorry reviewed Mar 11, 2022
View reviewed changes
Copy link

@erikcorry erikcorry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some confusion possible because in the C API documentation an item is 32 bits (two values, two periods), whereas here it is 16 bits (one value, one period). I think it's

lib/rmt.toit Outdated Show resolved Hide resolved
lib/rmt.toit Outdated Show resolved Hide resolved
lib/rmt.toit Outdated Show resolved Hide resolved
lib/rmt.toit Outdated Show resolved Hide resolved
lib/rmt.toit Outdated Show resolved Hide resolved
src/resources/rmt_esp32.cc Outdated Show resolved Hide resolved
src/resources/rmt_esp32.cc Outdated Show resolved Hide resolved
lib/rmt.toit Outdated Show resolved Hide resolved
lib/rmt.toit Outdated Show resolved Hide resolved
tests/rmt_items_test.toit Outdated Show resolved Hide resolved
lask and others added 19 commits March 11, 2022 13:43
erikcorry
erikcorry approved these changes Mar 14, 2022
View reviewed changes
lib/rmt.toit Outdated Show resolved Hide resolved
lib/rmt.toit Outdated Show resolved Hide resolved
lib/rmt.toit Outdated Show resolved Hide resolved
lib/rmt.toit Outdated Show resolved Hide resolved
@lask
Apply suggestions from code review
2d9a4ba 
Co-authored-by: Erik Corry <erik@toit.io>
@lask lask merged commit 4d75817 into master Mar 15, 2022
@lask lask deleted the lask-rmt-primitives branch March 15, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floitsch floitsch floitsch left review comments

@erikcorry erikcorry erikcorry approved these changes

@kasperl kasperl Awaiting requested review from kasperl

Assignees
No one assigned
Labels
cla-signed The contributors have signed the CLA
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lask @erikcorry @floitsch