Fix coloring of Types with '-' in their name. #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Types like `X-Of` weren't highlighted as type.
kasperl
approved these changes
Feb 17, 2024
vscode/syntaxes/toit.tmLanguage.yaml
Outdated
| - name: entity.name.type.toit | ||
| match: \b(?<!-)_?[A-Z][A-Z_-]*[a-z][\w-]*(?<!-)\b[?]? | ||
| - name: entity.name.type.toit | ||
| match: \b(?<!-)_?[A-Z][0-9]*(?<!-)\b[?]? |
There was a problem hiding this comment.
Do we have special handling for prefix underscores here?
There was a problem hiding this comment.
Not sure why we have it. (Maybe still old privacy syntax).
That said, I think I would expect _A to be a type.
In the end it's just an heuristic.
That said: it doesn't cover the A_ case, which should also be a type.
Added that.
done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types like
X-Ofweren't highlighted as type.