Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README. #110

Merged
merged 16 commits into from
Aug 6, 2024
Merged

Conversation

floitsch
Copy link
Member

@floitsch floitsch commented Jul 1, 2024

No description provided.

floitsch added 7 commits July 1, 2024 10:50
We need to populate the known-hosts file to avoid MITM attacks.
Interactively, ssh would ask the user to verify a key, but in a docker
container that's not possible. That's why we fill them beforehand.

If another server is needed, use the ENV variable 'SSH_KNOWN_HOSTS' or
create a new docker image that inherits from this one.
@floitsch floitsch requested a review from kasperl July 1, 2024 17:39
Copy link
Contributor

@kasperl kasperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

README-dev.md Outdated
``` shell
ssh-keygen -t ed25519
```
* Copy the public key into the deploy keys on Github: https://github.com/XXX/YYY/settings/keys.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Copy the public key into the deploy keys on Github: https://github.com/XXX/YYY/settings/keys.
* Copy the public key into the deploy keys on GitHub: https://github.com/XXX/YYY/settings/keys.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

README-dev.md Outdated
@@ -0,0 +1,34 @@
# Toit Package Manager - Development
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Toit Package Manager - Development
# Toit package manager - development

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

README-dev.md Outdated
```


## Tips and Tricks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Tips and Tricks
## Tips and tricks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Base automatically changed from floitsch/bake-known-hosts.key-env.build-args to main August 6, 2024 08:18
@floitsch floitsch enabled auto-merge (squash) August 6, 2024 08:23
@floitsch floitsch merged commit 1eef495 into main Aug 6, 2024
2 checks passed
@floitsch floitsch deleted the floitsch/bake-known-hosts.key-env.build-args.readme branch August 6, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants