Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bake secrets into docker image. #73

Merged
merged 9 commits into from
Jul 27, 2022
Merged

Bake secrets into docker image. #73

merged 9 commits into from
Jul 27, 2022

Conversation

floitsch
Copy link
Member

@floitsch floitsch commented Jul 8, 2022

No need to have the deployment mount the secrets.
This makes it easier to develop locally, and to host the registry server
in a different environment.

floitsch added 3 commits July 7, 2022 20:08
@floitsch
Use https access for git submodule.
faa62f8
@floitsch
Switch to Github Actions.
1bc7f9e
@floitsch
Bake secrets into docker image.
a48591f 
No need to have the deployment mount the secrets.
This makes it easier to develop locally, and to host the registry server
in a different environment.
@floitsch floitsch requested review from mmedum and kasperl July 8, 2022 09:29
kasperl
kasperl approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@kasperl kasperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Base automatically changed from floitsch/rm_jenkins.20.switch to main July 27, 2022 10:25
@floitsch floitsch enabled auto-merge (squash) July 27, 2022 10:28
@floitsch floitsch merged commit d6d7d8b into main Jul 27, 2022
@floitsch floitsch deleted the floitsch/rm_jenkins.30.bake_in_secrets branch July 27, 2022 10:31
floitsch added a commit that referenced this pull request Oct 5, 2023
@floitsch
Revert "Bake secrets into docker image. (#73)"
0c86e85 
This reverts commit d6d7d8b.
floitsch added a commit that referenced this pull request Oct 5, 2023
@floitsch
Revert "Bake secrets into docker image. (#73)" (#89)
9ff74fe 
This reverts commit d6d7d8b.
floitsch added a commit that referenced this pull request Oct 6, 2023
@floitsch
Revert "Revert "Bake secrets into docker image. (#73)" (#89)"
f7c13d0 
This reverts commit 9ff74fe.
floitsch added a commit that referenced this pull request Oct 6, 2023
@floitsch
Bake secrets in pod and show known hosts (#90)
c0daa8e 
* Revert "Revert "Bake secrets into docker image. (#73)" (#89)"

This reverts commit 9ff74fe.

* Cat the known hosts.
floitsch added a commit that referenced this pull request Jun 28, 2024
@floitsch
Revert "Bake secrets into docker image. (#73)"
52cb19e 
This reverts commit d6d7d8b.
floitsch added a commit that referenced this pull request Jun 28, 2024
@floitsch
Revert "Bake secrets into docker image. (#73)" (#97)
09e9371 
This reverts commit d6d7d8b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperl kasperl kasperl approved these changes

@mmedum mmedum Awaiting requested review from mmedum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@floitsch @kasperl