Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mat4.fromRotationTranslationScaleOrigin slight speedup #246

Merged
merged 3 commits into from
Apr 3, 2018

Conversation

flowtsohg
Copy link
Contributor

Cached local array accesses.

I doubt many people will notice the difference.
My library calls this function possibly millions of times per second, so every bit of speed counts.

@toji
Copy link
Owner

toji commented Jul 21, 2017

This change needs to be rebased against master now that #249 has landed, but I'd be happy to merge it at that point, thanks!

@stefnotch
Copy link
Collaborator

stefnotch commented Nov 23, 2017

@flowtsohg Mind updating your pull request? It currently has a bunch of conflicts.

@flowtsohg
Copy link
Contributor Author

I am not very experienced with Github, does this mean I need to re-fork the repository and re-pull?

@stefnotch
Copy link
Collaborator

@flowtsohg You don't need a new fork. You have to pull from the latest master, fix the merge conflicts and then, you would have to commit and push.

Though, it should be easily possible to resolve the merge conflicts right here in the browser: https://help.github.com/articles/resolving-a-merge-conflict-on-github/

@flowtsohg
Copy link
Contributor Author

I am pretty sure I messed something up, but I guess it worked in the end. :)

@stefnotch
Copy link
Collaborator

@toji This change can now be merged.

@stefnotch
Copy link
Collaborator

@toji Mind merging this?

@stefnotch stefnotch merged commit 0184711 into toji:master Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants