Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable example reqwest-response back #2429

Closed
1 task done
gerardcl opened this issue Dec 16, 2023 · 1 comment · Fixed by #2430
Closed
1 task done

Enable example reqwest-response back #2429

gerardcl opened this issue Dec 16, 2023 · 1 comment · Fixed by #2430

Comments

@gerardcl
Copy link
Contributor

  • I have looked for existing issues (including closed) about this

Bug Report

Version

> cargo tree | grep axum
axum v0.7.2 (.../Development/Rust/axum/axum)
├── axum-core v0.4.1 (.../Development/Rust/axum/axum-core)
│   ├── axum v0.7.2 (.../Development/Rust/axum/axum) (*)
│   ├── axum-extra v0.9.0 (.../Development/Rust/axum/axum-extra)
│   │   ├── axum v0.7.2 (.../Development/Rust/axum/axum) (*)
│   │   ├── axum-core v0.4.1 (.../Development/Rust/axum/axum-core) (*)
│   │   ├── axum-macros v0.4.0 (proc-macro) (.../Development/Rust/axum/axum-macros)
│   │   │   ├── axum v0.7.2 (.../Development/Rust/axum/axum) (*)
│   │   │   ├── axum-extra v0.9.0 (.../Development/Rust/axum/axum-extra) (*)
│   │   ├── axum v0.7.2 (.../Development/Rust/axum/axum) (*)
├── axum-macros v0.4.0 (proc-macro) (.../Development/Rust/axum/axum-macros) (*)
├── axum-macros v0.4.0 (proc-macro) (.../Development/Rust/axum/axum-macros) (*)
axum-core v0.4.1 (.../Development/Rust/axum/axum-core) (*)
axum-extra v0.9.0 (.../Development/Rust/axum/axum-extra) (*)
axum-macros v0.4.0 (proc-macro) (.../Development/Rust/axum/axum-macros) (*)

Platform

> uname -a
Linux gerardcl 5.15.0-91-generic #101-Ubuntu SMP Tue Nov 14 13:30:08 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Crates

no crates, but examples folder

Description

I tried to run:

cargo run -p example-reqwest-response

And, I realised that it was all commented out.

Checking deeper, I realised both axum and reqwest crates use different http crate versions, 1.0.0 and 0.2.11 respectively.

So, I decided I could contribute back with a fix that does not depend on the reqwest update.
gerardcl added a commit to gerardcl/axum that referenced this issue Dec 16, 2023
@gerardcl
Fixes: tokio-rs#2429
f4c9ae9
@gerardcl gerardcl mentioned this issue Dec 16, 2023
Merged
@davidpdrsn
Copy link
Member

We're tracking the examples in #2356

@davidpdrsn davidpdrsn closed this as not planned Won't fix, can't repro, duplicate, stale Dec 17, 2023
gerardcl added a commit to gerardcl/axum that referenced this issue Dec 17, 2023
@gerardcl
Refs: tokio-rs#2356, tokio-rs#2429 - reqwest-response example for axu…
2e7ac83 
…m 0.7
gerardcl added a commit to gerardcl/axum that referenced this issue Dec 17, 2023
@gerardcl
Refs: tokio-rs#2356, tokio-rs#2429 - reqwest-response example for axu…
93799cf 
…m 0.7
gerardcl added a commit to gerardcl/axum that referenced this issue Dec 18, 2023
@gerardcl
Refs: tokio-rs#2356, tokio-rs#2429 - improve comments on reqwest-resp…
07f9108 
…onse example for axum 0.7
gerardcl added a commit to gerardcl/axum that referenced this issue Dec 18, 2023
@gerardcl
Refs: tokio-rs#2356, tokio-rs#2429 - comments on reqwest-response exa…
516593e 
…mple for axum 0.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update example-reqwest-response gerardcl/axum
2 participants
@davidpdrsn @gerardcl