Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

axum-extra should depend on tower with default_features = false #659

Closed
davidpdrsn opened this issue Dec 27, 2021 · 0 comments · Fixed by #666
Closed

axum-extra should depend on tower with default_features = false #659

davidpdrsn opened this issue Dec 27, 2021 · 0 comments · Fixed by #666

Comments

@davidpdrsn
Copy link
Member

Otherwise tower will enable tracing's log feature, which users might not want (I wish tower didn't do this). Changing this technically a breaking change but might be acceptable in a minor release 🤷

Probably not worth adding a tower-log feature like axum has, to axum-extra, since users who depend on axum-extra probably also depends on axum so they can enable the feature there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant