-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypedHeaderRejectionReason should be non_exhaustive #660
Labels
A-axum
breaking change
A PR that makes a breaking change.
E-easy
Call for participation: Experience needed to fix: Easy / not much
Milestone
Comments
jplatte
added
E-easy
Call for participation: Experience needed to fix: Easy / not much
breaking change
A PR that makes a breaking change.
A-axum
labels
Dec 27, 2021
davidpdrsn
added a commit
that referenced
this issue
Dec 27, 2021
So we can add new variants in the future without breaking changes. Fixes #660
davidpdrsn
added a commit
that referenced
this issue
Dec 27, 2021
davidpdrsn
added a commit
that referenced
this issue
Dec 27, 2021
* Make `TypedHeaderRejectionReason` `#[non_exhaustive]` Fixes #660 * add changelog pr link
Fixed in #665 |
davidpdrsn
added a commit
that referenced
this issue
Jan 3, 2022
* Make `TypedHeaderRejectionReason` `#[non_exhaustive]` Fixes #660 * add changelog pr link
davidpdrsn
added a commit
that referenced
this issue
Jan 3, 2022
* Make `TypedHeaderRejectionReason` `#[non_exhaustive]` Fixes #660 * add changelog pr link
davidpdrsn
added a commit
that referenced
this issue
Jan 23, 2022
* Make `TypedHeaderRejectionReason` `#[non_exhaustive]` Fixes #660 * add changelog pr link
davidpdrsn
added a commit
that referenced
this issue
Jan 23, 2022
* Make `TypedHeaderRejectionReason` `#[non_exhaustive]` Fixes #660 * add changelog pr link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-axum
breaking change
A PR that makes a breaking change.
E-easy
Call for participation: Experience needed to fix: Easy / not much
TypedHeaderRejectionReason
, like most rejection(-related) enums, should be non-exhaustive from the next breaking-change release onwards so after that, adding new variants can be done in non-breaking releases.The text was updated successfully, but these errors were encountered: