Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to tokio-tungstenite 0.17 #781

Closed
davidpdrsn opened this issue Feb 22, 2022 · 0 comments · Fixed by #791
Closed

Update to tokio-tungstenite 0.17 #781

davidpdrsn opened this issue Feb 22, 2022 · 0 comments · Fixed by #791
Labels
A-axum
Milestone
0.5

Comments

@davidpdrsn
Copy link
Member

davidpdrsn commented Feb 22, 2022 •
edited
Loading

They've added a new Frame variant to the Message enum. Have to figure out how to best handle that. Frame is quite a large type with a bunch of related types like FrameHeader, OpCode, etc. Ideally we didn't have to copy the whole thing.

Edit: Asked the tungstenite maintainers for their advice snapview/tungstenite-rs#268
@davidpdrsn davidpdrsn added this to the 0.5 milestone Feb 22, 2022
davidpdrsn added a commit that referenced this issue Feb 24, 2022
@davidpdrsn
Update to tokio-tungstenite 0.17
c6226d2 
Fixes #781
@davidpdrsn davidpdrsn mentioned this issue Feb 24, 2022
Merged
davidpdrsn added a commit that referenced this issue Feb 24, 2022
@davidpdrsn
Update to tokio-tungstenite 0.17
b2f7c5c 
Fixes #781
davidpdrsn added a commit that referenced this issue Feb 25, 2022
@davidpdrsn
Update to tokio-tungstenite 0.17 (#791)
4ccc4be 
Fixes #781
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-axum
Projects
None yet
Milestone
0.5
Development

Successfully merging a pull request may close this issue.

Update to tokio-tungstenite 0.17 tokio-rs/axum
1 participant
@davidpdrsn