Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement into Uri for TypedPath #789

Closed
norman784 opened this issue Feb 24, 2022 · 1 comment · Fixed by #790
Closed

Implement into Uri for TypedPath #789

norman784 opened this issue Feb 24, 2022 · 1 comment · Fixed by #790
Labels
A-axum-macros C-feature-request Category: A feature request, i.e: not implemented / a PR.

Comments

@norman784
Copy link

Feature Request

Add ergonomic improvements to TypedPath

Motivation

It feels so off to write Redirect::temporary(MyPath.to_string().parse().unwrap()) instead of Redirect::temporary(MyPath.into_uri()).

Proposal

Add and implement a new trait IntoUri to TypedPath.

Alternatives

Maybe Into<Uri> works also just fine, the only open question is if/how can fail to generate the Uri.
@davidpdrsn davidpdrsn added A-axum-macros C-feature-request Category: A feature request, i.e: not implemented / a PR. labels Feb 24, 2022
@davidpdrsn
Copy link
Member

Good call! I think we should implement TryFrom<MyPath> for Uri where the error type is InvalidUri.

davidpdrsn added a commit that referenced this issue Feb 24, 2022
@davidpdrsn
Easily convert typed paths into URIs
9e1bca3 
`#[derive(TypedPath)]` will now also generate `TryFrom<_> for Uri` for
easily converting paths into URIs for use with `Redirect` and friends.

Fixes #789
@davidpdrsn davidpdrsn mentioned this issue Feb 24, 2022
Merged
davidpdrsn added a commit that referenced this issue Feb 24, 2022
@davidpdrsn
Easily convert typed paths into URIs
e4e8990 
`#[derive(TypedPath)]` will now also generate `TryFrom<_> for Uri` for
easily converting paths into URIs for use with `Redirect` and friends.

Fixes #789
davidpdrsn added a commit that referenced this issue Feb 28, 2022
@davidpdrsn
Easily convert typed paths into URIs (#790)
da74084 
* Easily convert typed paths into URIs

`#[derive(TypedPath)]` will now also generate `TryFrom<_> for Uri` for
easily converting paths into URIs for use with `Redirect` and friends.

Fixes #789

* Use a method on the `TypedPath` trait to convert to `Uri`

* fix doc ref

* Update changelogs
davidpdrsn added a commit that referenced this issue Mar 1, 2022
@davidpdrsn
Easily convert typed paths into URIs (#790)
7d9d8c9 
* Easily convert typed paths into URIs

`#[derive(TypedPath)]` will now also generate `TryFrom<_> for Uri` for
easily converting paths into URIs for use with `Redirect` and friends.

Fixes #789

* Use a method on the `TypedPath` trait to convert to `Uri`

* fix doc ref

* Update changelogs
davidpdrsn added a commit that referenced this issue Mar 1, 2022
@davidpdrsn @matze
Backport TypedPath::to_uri (#809)
84cbb66 
* axum-macros: use fully qualified Result type (#796)

* Easily convert typed paths into URIs (#790)

* Easily convert typed paths into URIs

`#[derive(TypedPath)]` will now also generate `TryFrom<_> for Uri` for
easily converting paths into URIs for use with `Redirect` and friends.

Fixes #789

* Use a method on the `TypedPath` trait to convert to `Uri`

* fix doc ref

* Update changelogs

* Remove out of date docs

These accidentally weren't removed in #790

Co-authored-by: Matthias Vogelgesang <matthias.vogelgesang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-axum-macros C-feature-request Category: A feature request, i.e: not implemented / a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Easily convert typed paths into URIs tokio-rs/axum
2 participants
@norman784 @davidpdrsn