-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically handle http_body::LengthLimitError
#1048
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidpdrsn
force-pushed
the
handle-length-limit-error
branch
2 times, most recently
from
June 6, 2022 18:45
988e093
to
b97df02
Compare
davidpdrsn
force-pushed
the
handle-length-limit-error
branch
from
June 6, 2022 18:53
b97df02
to
56215e7
Compare
davidpdrsn
force-pushed
the
handle-length-limit-error
branch
from
June 6, 2022 19:04
e664b34
to
68e6c59
Compare
jplatte
reviewed
Jun 8, 2022
davidpdrsn
force-pushed
the
handle-length-limit-error
branch
from
June 8, 2022 13:17
b6c6f08
to
3c3f1ce
Compare
jplatte
reviewed
Jun 8, 2022
Co-authored-by: Jonas Platte <jplatte+git@posteo.de>
jplatte
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds special handling of
http_body::LengthLimitError
toFailedToBufferBody
such that this just works and returns413 Payload Too Large
if the limit is exceeded.tower-http's new
RequestBodyLimitLayer
uses that so limiting both requests with a known length and streaming is just:I think changing
ContentLengthLimit
to usehttp_body::Limited
would be good but we cannot do that without breaking changes since it requiresT: FromRequest<B>
but we have to change that toT: FromRequest<Limited<B>>
.EDIT: Actually I don't think we can do that since you cannot change the body type in a
RequestParts
with only an&mut RequestParts
. You'd need an owned value 🤔