Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement IntoResponse for Form #1095

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Implement IntoResponse for Form #1095

merged 3 commits into from
Jun 17, 2022

Conversation

davidpdrsn
Copy link
Member

I figure this makes sense to support though not the most useful thing ever.

Required moving the form module to the root and re-exporting Form from both extract and response.

@davidpdrsn davidpdrsn requested a review from jplatte June 15, 2022 21:14
@davidpdrsn davidpdrsn enabled auto-merge (squash) June 15, 2022 21:14
@jplatte
Copy link
Member

jplatte commented Jun 16, 2022

So, what's the use case? 😄

@davidpdrsn
Copy link
Member Author

Well someone might wanna return url encoded data. Actix-web's Form also supports it.. I don't think it hurts to support 🤷

@davidpdrsn davidpdrsn merged commit 2f64064 into main Jun 17, 2022
@davidpdrsn davidpdrsn deleted the form-response branch June 17, 2022 18:23
@davidpdrsn davidpdrsn mentioned this pull request Jun 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte approved these changes

Assignees
No one assigned
Labels
A-axum
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidpdrsn @jplatte