Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence "unnecessary use of to_string" lint for #[derive(TypedPath)] #1117

Merged
merged 4 commits into from
Jun 27, 2022
Merged

Silence "unnecessary use of to_string" lint for #[derive(TypedPath)] #1117

merged 4 commits into from
Jun 27, 2022

Conversation

davidpdrsn
Copy link
Member

Fixes #1111

@davidpdrsn davidpdrsn requested a review from jplatte June 25, 2022 09:17
jplatte
jplatte reviewed Jun 27, 2022
View reviewed changes
Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a changelog saying "Fix", I would have expected the codegen skipping the unnecessary calls. Maybe change it to "Silence" the lint?

davidpdrsn
davidpdrsn commented Jun 27, 2022
View reviewed changes
axum-macros/CHANGELOG.md Outdated Show resolved Hide resolved
@davidpdrsn davidpdrsn changed the title Fix "unnecessary use of to_string" lint for #[derive(TypedPath)] Silence "unnecessary use of to_string" lint for #[derive(TypedPath)] Jun 27, 2022
@davidpdrsn davidpdrsn requested a review from jplatte June 27, 2022 10:10
@davidpdrsn davidpdrsn enabled auto-merge (squash) June 27, 2022 18:45
@davidpdrsn davidpdrsn mentioned this pull request Jun 27, 2022
Merged
@davidpdrsn davidpdrsn merged commit 11179b8 into main Jun 27, 2022
@davidpdrsn davidpdrsn deleted the fix-typed-path-to-string-warning branch June 27, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte approved these changes

Assignees
No one assigned
Labels
A-axum-macros
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typed_path produces "unnecessary use of to_string" lint warnings
2 participants
@davidpdrsn @jplatte