Add DefaultBodyLimit::max to change the body size limit
#1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
approved these changes
Sep 19, 2022
jplatte
pushed a commit
that referenced
this pull request
Oct 19, 2022
jplatte
pushed a commit
that referenced
this pull request
Oct 19, 2022
davidpdrsn
added a commit
that referenced
this pull request
Oct 20, 2022
malexandru-rdx
added a commit
to radixdlt/babylon-node
that referenced
this pull request
Mar 16, 2023
Update axum's version. Check breaking [changelog](https://github.com/tokio-rs/axum/blob/main/axum/CHANGELOG.md#060-25-november-2022). Remove Tower `RequestBodyLimitLayer` middleware and use `DefaultBodyLimit::max` (see TODO and tokio-rs/axum#1397).
keroro520
added a commit
to keroro520/raiko
that referenced
this pull request
Dec 19, 2024
The original implementation of check_max_body_size relied on the size_hint provided by Axum. However, we've encountered instances where check_max_body_size incorrectly returns a BAD_REQUEST response due to inaccurate size_hint values. This commit changes to use `DefaultBodyLimit`, which is the suggestion by axum. See also - tokio-rs/axum#1400 - tokio-rs/axum#1397
keroro520
added a commit
to keroro520/raiko
that referenced
this pull request
Dec 19, 2024
The original implementation of check_max_body_size relied on the size_hint provided by Axum. However, we've encountered instances where check_max_body_size incorrectly returns a BAD_REQUEST response due to inaccurate size_hint values. This commit changes to use `DefaultBodyLimit`, which is the suggestion by axum. See also - tokio-rs/axum#1400 - tokio-rs/axum#1397
github-merge-queue bot
pushed a commit
to taikoxyz/raiko
that referenced
this pull request
Dec 25, 2024
The original implementation of check_max_body_size relied on the size_hint provided by Axum. However, we've encountered instances where check_max_body_size incorrectly returns a BAD_REQUEST response due to inaccurate size_hint values. This commit changes to use `DefaultBodyLimit`, which is the suggestion by axum. See also - tokio-rs/axum#1400 - tokio-rs/axum#1397
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1370
We now have a few ways to set body limits:
DefaultBodyLimit::maxContentLengthLimittower_http::limit::RequestBodyLimitandhttp_body::LimitedI don't we should remove anything tower-http and http-body but I feel we should consider removing
ContentLengthLimit. It can essentially be replaced with