Add Body::from_stream
#1752
Merged
Add Body::from_stream
#1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by hyper's `Body::wrap_stream`.
davidpdrsn
force-pushed
the
body-from-stream
branch
from
644bf3e to
c5ce4b9
Compare
jplatte
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by hyper's
Body::wrap_stream.With this we can remove
StreamBodybut I think I'll do that in another PR as it impacts things likeAsyncReadBody.Maybe we could also add
Body::from_async_read? Though that'd require axum-core to depend on tokio-util 🤔