Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin itoa dependency #1815

Merged
merged 1 commit into from
Mar 5, 2023
Merged

Unpin itoa dependency #1815

merged 1 commit into from
Mar 5, 2023

Conversation

alexheretic
Copy link
Contributor

Motivation

Resolves #1814

davidpdrsn
davidpdrsn approved these changes Mar 5, 2023
View reviewed changes
Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I once lost an evening to very odd test failures that pinning itoa fixed but that's not necessary then great!

@davidpdrsn davidpdrsn merged commit f9f64a3 into tokio-rs:main Mar 5, 2023
@djc
Copy link

djc commented Mar 13, 2023

Would it be possible to get this released? The situation described in #1814 isn't great.

@davidpdrsn davidpdrsn mentioned this pull request Mar 13, 2023
Merged
@davidpdrsn
Copy link
Member

@djc sure! #1843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpdrsn davidpdrsn davidpdrsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

axum pins itoa to 1.0.5 causing issues with cargo update
3 participants
@alexheretic @djc @davidpdrsn