Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve debug_handler message for generic request-consuming extractors #1826

Merged
merged 3 commits into from
Mar 10, 2023
Merged

Improve debug_handler message for generic request-consuming extractors #1826

merged 3 commits into from
Mar 10, 2023

Conversation

jplatte
Copy link
Member

@jplatte jplatte commented Mar 7, 2023

Motivation

Fixes #1738.

Solution

Set the generic parameter to ViaRequest in the debug_handler check function for the last parameter if its type is known to consume the request.

@jplatte jplatte requested a review from davidpdrsn March 7, 2023 13:14
davidpdrsn
davidpdrsn approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jplatte jplatte enabled auto-merge (squash) March 10, 2023 08:44
@jplatte jplatte merged commit a26ddd1 into main Mar 10, 2023
@jplatte jplatte deleted the jplatte/macro-stuff branch March 10, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpdrsn davidpdrsn davidpdrsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#[debug_handler] could suggest Deserialize for Json
2 participants
@jplatte @davidpdrsn