Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the state clones by 1 for each request. Not much but better than nothing. Had to inline the
call_route
to get around some borrowing issues.The remaining clones are
Handler::call
takeS
by reference rather than value. Not sure what the implications are. Think the response future should still be'static
so might not be possible.State
extractor viaFromRef
. That needs to produce an owned state.Route::call
usesoneshot
which requiresclone
. Not sure its possible to fix but worth investigating.call
onShared
that clones the service)Part of #1827