Update to syn 2 #1862
Merged
Update to syn 2 #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidpdrsn
commented
Mar 18, 2023
| @@ -23,6 +23,8 @@ skip-tree = [ | |||
| { name = "windows-sys" }, | |||
| # old version pulled in by rustls via ring | |||
| { name = "spin" }, | |||
| # lots still pulls in syn 1.x | |||
| { name = "syn" }, | |||
There was a problem hiding this comment.
I tried to remove duplicate syn versions but still lots of crates that need to be updated. I'm gonna submit some patches but don't it should block us from updating.
jplatte
approved these changes
Mar 18, 2023
jplatte
reviewed
Mar 19, 2023
| @@ -62,7 +62,7 @@ where | |||
| { | |||
| attrs | |||
| .iter() | |||
| .filter(|attr| attr.path.is_ident(ident)) | |||
| .filter(|attr| attr.meta.path().is_ident(ident)) | |||
There was a problem hiding this comment.
Having just upgraded another project to syn 2, I realized you used a more verbose solution than necessary here. Attribute also has a path method, so this can be attr.path().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀