Add OptionalPath extractor #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
commented
Mar 27, 2023
jplatte
force-pushed
the
jplatte/optional-path
branch
from
e040c06
to
fe689be
Compare
davidpdrsn
reviewed
Mar 27, 2023
jplatte
force-pushed
the
jplatte/optional-path
branch
from
fe689be
to
1885dd4
Compare
|
I'll do the last view changes now. |
davidpdrsn
approved these changes
Apr 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #1884.
Solution
What was already written on the issue 😄
I also had to add
kind()toFailedToDeserializePathParams. I don't think we should really have bothkind()andinto_kind()but I wasn't too sure what it should look like and went for roughly the path of least resistance (it would have been easier to return&ErrorKindbut I'm guessing we don't want to guarantee that the rejection holds anErrorKind).