Implement Clone for ErasedJson #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidpdrsn
approved these changes
Aug 2, 2023
|
Hope you don't mind me drive-by removing the duplicate "added" from the changelog ^^ |
davidpdrsn
approved these changes
Aug 2, 2023
jplatte
added a commit
that referenced
this pull request
Aug 2, 2023
jplatte
added a commit
that referenced
this pull request
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Makes
ErasedJsonaHandler. Also kinda expected, maybe? All ofJson,Htmland so on implementClone.Solution
Implement
Clone. Requires the serde_json error to be wrapped inArcbecause it's notClone, but failing to serialize should be an extremely rare edge-case.