Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSRV of axum-macros is 1.63 #2204

Merged
merged 2 commits into from
Sep 11, 2023
Merged

MSRV of axum-macros is 1.63 #2204

merged 2 commits into from
Sep 11, 2023

Conversation

nabbisen
Copy link
Contributor

@nabbisen nabbisen commented Sep 5, 2023

Motivation

I found typo in README.md in axum-macros compared with Cargo.toml.

README.md:

axum-macros's MSRV is 1.63.

Cargo.toml:

rust-version = "1.60"

Solution

I believed tests had been done with the current Cargo.toml and therefore thought README.md should have been fixed.

@davidpdrsn
Copy link
Member

I think the typo is actually in the Cargo.toml. Our MSRV is 1.63.

@nabbisen
Copy link
Contributor Author

nabbisen commented Sep 5, 2023

@davidpdrsn

I think the typo is actually in the Cargo.toml. Our MSRV is 1.63.

Thank you for your comments. I'll recreate PR soon by reverting README.md and modifying Cargo.toml.

@nabbisen
Copy link
Contributor Author

nabbisen commented Sep 5, 2023

After modifying Cargo.toml in axum-macros, running cargo build in axum (the root directory) succeeded.

[environment]
OS: Devuan 5 (based on Debian without systemd)
Toolchain: rustup
Rust: 1.72.0 (stable channel)

@davidpdrsn davidpdrsn enabled auto-merge (squash) September 5, 2023 14:22
@jplatte jplatte changed the title fix typo in axum-macros README: according to Cargo.toml msrv is 1.60 Update MSRV of axum-macros: 1.60 -> 1.63 Sep 5, 2023
@davidpdrsn
Copy link
Member

You can ignore the CI error. I'll fix that in a separate PR.

@Rustin170506
Copy link
Contributor

You can ignore the CI error. I'll fix that in a separate PR.

I think this is a false positive. Upgrading the beta version would fix it.

@davidpdrsn davidpdrsn changed the title Update MSRV of axum-macros: 1.60 -> 1.63 MSRV of axum-macros is 1.63 Sep 11, 2023
@davidpdrsn davidpdrsn merged commit 7017198 into tokio-rs:main Sep 11, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants