Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tokio an optional dependency of axum-extra #2236

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

davidpdrsn
Copy link
Member

Requested by someone in Discord. That way you can use axum-extra in wasm, as long as you don't enable the features that require tokio. We already do this for axum but think we just forgot axum-extra.

@jplatte I'm right in this being a breaking change right? 🤔

@davidpdrsn davidpdrsn requested a review from jplatte September 21, 2023 07:22
@davidpdrsn davidpdrsn enabled auto-merge (squash) September 21, 2023 07:23
Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how this would be a breaking change. Maybe try cargo-semver-checks locally? By default it compares the current state against the crates.io release. It's still missing lots of lints AFAIK, but better to run it than not to.

@davidpdrsn davidpdrsn merged commit 3b3bbb2 into main Sep 21, 2023
@davidpdrsn davidpdrsn deleted the david/tokio-optional-dep-axum-extra branch September 21, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants